Skip to content

@W-20136880: BOPIS for 1CC#3460

Merged
kumaravinashcommercecloud merged 4 commits intofeature/1cc_paymentsfrom
avinash.bopis
Nov 11, 2025
Merged

@W-20136880: BOPIS for 1CC#3460
kumaravinashcommercecloud merged 4 commits intofeature/1cc_paymentsfrom
avinash.bopis

Conversation

@kumaravinashcommercecloud
Copy link
Contributor

@kumaravinashcommercecloud kumaravinashcommercecloud commented Nov 7, 2025 •
edited
Loading

Description

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Nov 7, 2025 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Licenses 0 0 0 0 0 issues
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@kumaravinashcommercecloud kumaravinashcommercecloud added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Nov 7, 2025
@kumaravinashcommercecloud kumaravinashcommercecloud changed the base branch from feature/1cc_payments to feature/1cc_payments_REBASE November 11, 2025 15:31
@kumaravinashcommercecloud kumaravinashcommercecloud changed the base branch from feature/1cc_payments_REBASE to feature/1cc_payments November 11, 2025 15:32
dannyphan2000
dannyphan2000 reviewed Nov 11, 2025
View reviewed changes
Copy link
Contributor

@dannyphan2000 dannyphan2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run npm run lint:fix or something similar to fix the linting issues (i see them in the build)

@kumaravinashcommercecloud
Copy link
Contributor Author

kumaravinashcommercecloud commented Nov 11, 2025 •
edited
Loading

Can you run npm run lint:fix or something similar to fix the linting issues (i see them in the build)

Yes I did and confirmed that there are no new lint errors or warnings associated with changes in the PR. The base feature branch itself has several errors and warnings though.

image

There are lint issues in other non-checkout files that I have not included in the screenshot above.

dannyphan2000
dannyphan2000 approved these changes Nov 11, 2025
View reviewed changes
Copy link
Contributor

@dannyphan2000 dannyphan2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaravinashcommercecloud kumaravinashcommercecloud merged commit 1b74868 into feature/1cc_payments Nov 11, 2025
10 of 42 checks passed
@kumaravinashcommercecloud kumaravinashcommercecloud deleted the avinash.bopis branch November 11, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dannyphan2000 dannyphan2000 dannyphan2000 approved these changes

Assignees

No one assigned

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kumaravinashcommercecloud @cc-prodsec @dannyphan2000